First Last Prev Next    No search results available
Details
: Potentially collocated IORs demarshaled as nil references
Bug#: 1535
: TAO
: POA
Status: RESOLVED
Resolution: FIXED
: All
: All
: 1.3.1
: P3
: normal
: ---

:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Carlos O'Ryan <coryan@atdesk.com>
Assigned To: Irfan Pyarali <irfan@oomworks.com>

Attachments
Suggested patch (813 bytes, patch)
2003-06-12 12:32, Carlos O'Ryan
Details | Diff
My proposed (untested) changes (4.36 KB, patch)
2003-06-12 14:40, Irfan Pyarali
Details | Diff
TAR file with the regrssion test.... (10.00 KB, application/octet-stream)
2004-11-09 06:15, Carlos O'Ryan
Details
Proposed fixes, the regression test passes, still running full testsuite (4.84 KB, patch)
2004-11-09 06:24, Carlos O'Ryan
Details | Diff


Note

You need to log in before you can comment on or make changes to this bug.

Related actions
Votes: 0


Description:   Opened: 2003-06-12 12:32
ThruPOA collocation does not require a servant, however, the collocation flags
are disabled if the servant cannot be found when the object reference is created.
This wastes opportunities for collocation, as object references created before
the servant (say via string_to_object() or via create_reference_with_id()) will
not be collocated though they could be.
------- Comment #1 From Carlos O'Ryan 2003-06-12 12:32:53 -------
Created an attachment (id=217) [details]
Suggested patch
------- Comment #2 From Irfan Pyarali 2003-06-12 14:40:15 -------
Created an attachment (id=218) [details]
My proposed (untested) changes
------- Comment #3 From Carlos O'Ryan 2003-06-12 14:44:40 -------
Irfan's changes look better
------- Comment #4 From Irfan Pyarali 2003-06-17 14:04:50 -------
Accepted.  Here is the general description of the fix:

As long as there is a profile match, we should create a collocated
object.  If we can find the servant, well and good.  If not, it will
be resolved later or an exception will be thrown by the POA.  There is
no point in creating a remote object after the profiles match since
the remote invocation will be handled by the local ORB.  DIRECT
collocation users beware, you must have the servant available when the
Object is created.

Once we have a test, we can check in the patches.
------- Comment #5 From Irfan Pyarali 2003-07-22 16:56:40 -------
Fixed. 

ChangeLogTag: Tue Jul 22 16:57:06 2003  Irfan Pyarali  <irfan@oomworks.com>
------- Comment #6 From Carlos O'Ryan 2004-11-09 06:12:57 -------
The bug was reintroduced before 1.4.2.  I will attach a proposed patch and a
regression test shortly.
------- Comment #7 From Carlos O'Ryan 2004-11-09 06:15:50 -------
Created an attachment (id=291) [details]
TAR file with the regrssion test....
------- Comment #8 From Carlos O'Ryan 2004-11-09 06:24:37 -------
Created an attachment (id=292) [details]
Proposed fixes, the regression test passes, still running full testsuite
------- Comment #9 From Carlos O'Ryan 2004-11-09 07:29:18 -------
Changing the summary.  Unlike previous incarnations of the bug this one nows
returns a nil reference when the object is not demarshaled properly.  Needless
to say that is a more serious problem that just a performance issue.
------- Comment #10 From Nanbor Wang 2004-11-21 08:36:21 -------
Fixed using Carlos's patches. Thanks Carlos!

Sun Nov 14 05:01:28 2004  Balachandran Natarajan  <bala@dre.vanderbilt.edu>
------- Comment #11 From Carlos O'Ryan 2005-04-04 17:12:04 -------
The bug is showing up again on 1.4.3

This is the second or third time that I have to reopen this bug.  I have sent a
regression test already.  What is the excuse for not using the regression test?
------- Comment #12 From Carlos O'Ryan 2005-04-04 17:39:50 -------
Doh!  The fix (and regression test) is in the current CVS version.  Apologies.

First Last Prev Next    No search results available